Todo List¶
Todo
This function, eos_had_base::f_number_suscept(), should be overloaded for Skyrme with derivatives
(The original entry is located in <breathe>, line 1.)
Todo
This function, eos_had_base::f_inv_number_suscept(), should be overloaded for Skyrme with derivatives
(The original entry is located in <breathe>, line 1.)
Todo
In eos_had_ddc::calc_eq_e(): is the thermodynamic identity is satisfied even when the field equations are not solved? Check this.
(The original entry is located in <breathe>, line 1.)
Todo
In class eos_had_rmf:
The functions fcomp_fields(), fkprime_fields(), and fesym_fields() are not quite correct if the neutron and proton masses are different. For this reason, they are currently unused by saturation().
The fix_saturation() and calc_cr() functions use mnuc, and should be modified to allow different neutron and proton masses.
Check the formulas in the “Background” section
Make sure that this class properly handles particles for which inc_rest_mass is true/false
The calc_e() function fails to converge at lower densities. See the testing code which has trouble with NL3 and RAPR.
(The original entry is located in <breathe>, line 1.)
Todo
In class eos_had_rmf_hyp:
The couplings in the test code match the table but the maximum masses appear much smaller than GM91. I need to check that muons are added correctly, and it might be good to compare with a different reference. This also might be due to a different crust EOS.
The interpretation of the calc_e() function is a bit unclear, so I need to more clearly figure out what that function ought to do. I don’t think it’s really used at the moment.
(The original entry is located in <breathe>, line 1.)
Todo
In eos_had_schematic::set_a_from_mstar(): This was computed in schematic_sym.nb, which might be added to the documentation?
(The original entry is located in <breathe>, line 1.)
Todo
This function, eos_had_schematic::baryon_suscep() is untested.
(The original entry is located in <breathe>, line 1.)
Todo
In class eos_had_skyrme:
Convert W0 to b4 and b4p everywhere
Remove use of mnuc in calparfun()?
Update reference list.
(The original entry is located in <breathe>, line 1.)
Todo
This function, eos_had_skyrme::landau_nuclear() needs to be checked.
(The original entry is located in <breathe>, line 1.)
Todo
This function, eos_had_skyrme::landau_neutron() needs to be checked.
(The original entry is located in <breathe>, line 1.)
Todo
In function eos_had_skyrme::calpar():
Does this work for both ‘a’ and ‘b’ non-zero?
Compare to similar formulas in [Margueron02].
(The original entry is located in <breathe>, line 1.)
Todo
In eos_had_skyrme::alt_params_set(): These expressions are not exactly the same as those in [Bender03], so I need to find out why and make this more clear.
(The original entry is located in <breathe>, line 1.)
Todo
In class eos_nse_full: I don’t think inc_lept_phot=false works because then all WS cells have infinite size because of no electrons. For the moment, this variable is protected to discourage the user from changing it.
(The original entry is located in <breathe>, line 1.)
Todo
In eos_quark_cfl::calc_eq_temp_p(): It surprises me that n3 is not -res[11]. Is there a sign error in the color densities?
(The original entry is located in <breathe>, line 1.)
Todo
In eos_quark_cfl::gapped_eigenvalues(): In the code, the equal mass case seems to be commented out. Why?
(The original entry is located in <breathe>, line 1.)
Todo
In class eos_quark_njl: better documentation.
(The original entry is located in <breathe>, line 1.)
Todo
In class eos_sn_ls: There are still a few points for which the electron/photon EOS seems to be off, but this may be the result of small inaccuracies from finite-differencing the LS table.
(The original entry is located in <breathe>, line 1.)
Todo
In class eos_sn_stos: Add the T=0 and Ye=0 data to this class. Separate tables for these cases have been released, but I don’t think this class can read them yet.
(The original entry is located in <breathe>, line 1.)
Todo
In class nstar_rot:
Better documentation is needed everywhere.
Test the resize() function
It appears that KAPPA and KSCALE contant an arbitrary constant, try changing it and see if we get identical results. Try to ensure that the values are consistent between the eos_nstar_rot class and the nstar_rot class.
Variables r_is_gp, p_center, h_center, and others only occur in spherical_star(), integrate(), and make_center(), and can be moved to function parameters or otherwise reorganized.
Directly compare spherical_star() output with tov_solve results
(The original entry is located in <breathe>, line 1.)
Todo
In class nucmass_ldrop, 12/4/14: This doesn’t gracefully handle negative values of n0 and n1 as then the neutron and proton densities become negative. This needs to be addressed. For now, there is a fix at line 246 in nucmass_ldrop.cpp .
(The original entry is located in <breathe>, line 1.)
Todo
In class nucmass_ldrop_skin:
This is based on LPRL, but it’s a little different in Lattimer and Swesty. I should document what the difference is.
The testing could be updated.
(The original entry is located in <breathe>, line 1.)